Fix app env being reported as empty brackets (#1219)

appsignal · Jul 30, 2024 · cf08125 · cf08125
1 parent 53aa75d
commit cf08125
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/.changesets/fix-env-being-reported-as-----.md b/.changesets/fix-env-being-reported-as-----.md
@@ -0,0 +1,6 @@
+---
+bump: patch
+type: fix
+---
+
+Fix the application environment being reported as "[]" when no valid environment could be found.
diff --git a/lib/appsignal/config.rb b/lib/appsignal/config.rb
@@ -36,6 +36,8 @@ def self.determine_env(initial_env = nil)
         env = loader_defaults[:env]
         return env if env
       end
+
+      nil
     end
 
     # Determine which root path AppSignal should initialize with.

diff --git a/spec/lib/appsignal/config_spec.rb b/spec/lib/appsignal/config_spec.rb
@@ -67,6 +67,10 @@ def on_load
 
         expect(described_class.determine_env).to eq("loader_env2")
       end
+
+      it "returns nil if no env was found" do
+        expect(described_class.determine_env).to be_nil
+      end
     end
   end
-Original file line number
+Diff line change
@@ Expand Up / @@ -36,6 +36,8 @@ def self.determine_env(initial_env = nil) @@
             env = loader_defaults[:env]
             return env if env
           end
+          nil
         end
         # Determine which root path AppSignal should initialize with.
@@ Expand Down @@