Fix Capistrano tasks not logging anything

The loggers given to the Config class in the Capistrano tasks write to a StringIO which is never read afterwards. Call `_start_logger` to initialize the logger and write the buffered log messages either to STDOUT or the AppSignal log file after the config has loaded.
appsignal · Sep 26, 2024 · 089d032 · 089d032
1 parent 5f2acb5
commit 089d032
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.changesets/fix-no-logs-appearing-from-capistrano-tasks.md b/.changesets/fix-no-logs-appearing-from-capistrano-tasks.md
@@ -0,0 +1,6 @@
+---
+bump: patch
+type: fix
+---
+
+Fix no AppSignal internal logs being logged from Capistrano tasks.
diff --git a/lib/appsignal/integrations/capistrano/appsignal.cap b/lib/appsignal/integrations/capistrano/appsignal.cap
@@ -11,11 +11,12 @@ namespace :appsignal do
     appsignal_config = Appsignal::Config.new(
       Dir.pwd,
       appsignal_env,
-      Logger.new(StringIO.new)
+      Appsignal.internal_logger
     ).tap do |c|
       c.merge_dsl_options(fetch(:appsignal_config, {}))
       c.validate
     end
+    Appsignal._start_logger
 
     if appsignal_config&.active?
       marker_data = {

diff --git a/lib/appsignal/integrations/capistrano/capistrano_2_tasks.rb b/lib/appsignal/integrations/capistrano/capistrano_2_tasks.rb
@@ -19,11 +19,12 @@ def self.tasks(config)
               appsignal_config = Appsignal::Config.new(
                 ENV.fetch("PWD", nil),
                 env,
-                Appsignal::Utils::IntegrationLogger.new(StringIO.new)
+                Appsignal.internal_logger
               ).tap do |c|
                 c.merge_dsl_options(fetch(:appsignal_config, {}))
                 c.validate
               end
+              Appsignal._start_logger
 
               if appsignal_config&.active?
                 marker_data = {