[FLINK-38793][table] Reuse result of functions if ther are used multiple times as input for other functions #27328
+253
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidradl
reviewed
Dec 8, 2025
| RexNode project = bottomProjectList.get(i); | ||
| if (project instanceof RexCall | ||
| && SqlKind.FUNCTION.contains(((RexCall) project).op.getKind()) | ||
| && ((RexCall) project).op.isDeterministic()) { |
Contributor
There was a problem hiding this comment.
I do not know this area very well, just to check my understanding
- why are we calling the rexNodes projects and not rexNodes?
- I assume that
isDeterministicimplies that for a given input you get the same output. If there are non deterministic functions in the list of projects, this could imply we cannot use the output for those. Is it safe to reuse the results if there are non deterministic projects? What would it mean to re-use the results when there is a mix of deterministic and non-deterministic projects? Maybe have a test with the mix to ensure is works as you intend.
Contributor
Author
There was a problem hiding this comment.
this is still a kind of PoC
regarding deterministic: further in stack there is a dedicated check for deterministic/non-deterministic, so do not care much about this here
github-actions
bot
added
the
community-reviewed
…ple times as input for other functions
Remove commented-out code for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
It should reuse result of functions as input for other functions
Brief change log
projections rules
Verifying this change
There are tests in CalcTest
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation