Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ASF "stash" action to allow list of keys #45268

Open
potiuk opened this issue Dec 29, 2024 · 2 comments
Open

Update ASF "stash" action to allow list of keys #45268

potiuk opened this issue Dec 29, 2024 · 2 comments
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:dev-tools

Comments

@potiuk
Copy link
Member

potiuk commented Dec 29, 2024

In the new "caching" mechanism we are using "stash" GitHub action from @assignUser which only allows one key per action.

The action is in https://github.com/apache/infrastructure-actions/tree/main/stash

This is a a limiting factor when we want to download artifacts with a dynamic list of keys coming from a variable (say list of keys derived python versions - "3.9 3.10 3.11 3.12" -> "key-3.9 key-3.10 key-3.11 key-3.12".

Currently in #45266 (https://gtithub.com/apache/airflow/pull/45266/files#diff-a2dbc854d7d9f769ffe6efe98247baa68750cba87d785fb70d4616331010c7d0) we are hard-coding the possible actions to run with parameters and we are skipping those that are not on the list, but this is more of a hack than target solution.

Ideally we should be able to pass keys parameter to the action instead of key and be able to produce "hit-keys" list as output - then we could generate and pass the list of keys as input.

@potiuk potiuk converted this from a draft issue Dec 29, 2024
@dosubot dosubot bot added area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:dev-tools labels Dec 29, 2024
@assignUser
Copy link
Member

So you would want the action to be able to download multiple 'stash' artifacts and unpack them into a single dir? I can see how this would be useful to simplify this: https://github.com/apache/airflow/pull/45266/files#diff-a2dbc854d7d9f769ffe6efe98247baa68750cba87d785fb70d4616331010c7d0R43

The main motivation for the action was caching compiler caches for which this doesn't really make sense but when used as a more general actions/cache replacement this makes sense.

@potiuk
Copy link
Member Author

potiuk commented Dec 30, 2024

Yeah. That's the main motivation - to avoid hard-coding of the conditional cache retrieval :) .. We might have either me or someone from our team to contribute that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:dev-tools
Projects
Status: Ready
Development

No branches or pull requests

2 participants