Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taze change engines.vscode to a smaller version #144

Closed
6 of 7 tasks
ntnyq opened this issue Nov 25, 2024 · 0 comments · Fixed by #145
Closed
6 of 7 tasks

Taze change engines.vscode to a smaller version #144

ntnyq opened this issue Nov 25, 2024 · 0 comments · Fixed by #145

Comments

@ntnyq
Copy link
Contributor

ntnyq commented Nov 25, 2024

Describe the bug

I have engines.vscode set to version ^1.95.3 and @types/vscode set to version ^1.95.0 in package.json.

After run taze latest -rwI, taze changed engines.vscode to ^1.95.0.


Taze does a version sync from @types/vscode to engines.vscode.

But should it change to a smaller version? I don't think so.

Reproduction

https://github.com/ntnyq-dev/repro-taze-addon-vscode

System Info

System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 68.08 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.11.0 - ~/.local/state/fnm_multishells/42466_1732435531639/bin/node
    Yarn: 1.22.22 - ~/.yarn/bin/yarn
    npm: 10.9.0 - ~/.local/state/fnm_multishells/42466_1732435531639/bin/npm
    pnpm: 9.14.2 - ~/Library/pnpm/pnpm
    bun: 1.1.34 - ~/.bun/bin/bun
  Browsers:
    Chrome: 131.0.6778.86
    Edge: 131.0.2903.63
    Safari: 17.5

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant