Added test to reproduce problem with returning client to pool in a bad state

andrewdep · andrewdep · commit 832e48a82495 · 2012-07-23T12:36:54.000-05:00
If you start a transaction in a client and fail to roll that
transaction back before calling resumeDrain, then an unsuspecting user
will get an error the next time that client is pulled from the pool and
a query executed against it.
diff --git a/test/integration/connection-pool/error-recover-tests.js b/test/integration/connection-pool/error-recover-tests.js
@@ -0,0 +1,26 @@
+var helper = require(__dirname + "/../test-helper");
+var pg = require(__dirname + "/../../../lib");
+helper.pg = pg;
+
+helper.pg.defaults.poolSize = 1;
+
+test('aborted transaction returned to pool', function() {
+  helper.pg.connect(helper.config, assert.success(function(client) {
+    client.id = 1;
+    client.pauseDrain();
+    client.query('begin;', assert.success(function() {
+      // client.query('rollback;'); // <-- This causes the test to pass.
+      client.query('select * from thistableshouldneverexist', function(err) {
+        assert.ok(err);
+        client.resumeDrain();
+        helper.pg.connect(helper.config, assert.success(function(client) {
+          assert.equal(client.id, 1);
+          client.query("select * from person", assert.success(function(result) {
+            console.log('Ending', result);
+            helper.pg.end();
+          }));
+        }));
+      });
+    }));
+  }));
+});
