Download percentage added #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpg
reviewed
Aug 17, 2020
| let size = offlineFile.getFileSize() | ||
| let date = offlineFile.downloadDate?.asString ?? "" | ||
| let progress = offlineFile.progress * 100 | ||
| let dateSizeText = "\(Int(progress))% | \(size), \(date)" |
There was a problem hiding this comment.
Thanks for your contribution. I would suggest a change to this line for the following reasons:
- The date does not matter much while downloading
- The line keeps on moving because the % is variable font and has variable digits
- The
|keeps it a little busy
I would suggest
let dateSizeText = "\(size) · \(Int(progress))%"
There was a problem hiding this comment.
@cpg Thanks for your valuable feedback
1 I will not append the date while downloading.
2 I will add the percentage in last
3 i will add "." instead of "|"
Is this right?
There was a problem hiding this comment.
I made a precise suggestion of change for one line. If you like it, do it, if not, explain why and suggest otherwise.
There was a problem hiding this comment.
@cpg I liked your suggestion.
I am doing that way.
label tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the percentage text in sizeDateLabel in Download list collection cell
Fixes #347
@cpg Please review this