Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio Player Gestures #329

Merged
merged 13 commits into from
Jul 30, 2020
Merged

Audio Player Gestures #329

merged 13 commits into from
Jul 30, 2020

Conversation

ShresthPratapSingh
Copy link
Contributor

@ShresthPratapSingh ShresthPratapSingh commented Jul 27, 2020 •
edited
Loading

Description

This PR adds swipe gestures to navigate between songs.
This PR also implements progressively fetching of Metadata for better experience.

Fixes #205
Fixes #313
Fixes #325

Type of Change:

  • Code
  • Quality Assurance
  • User Interface

How Has This Been Tested?

Tested on iOS simulators(iOS 11, 12, 13) and on device (iOS 13.6)

Checklist:

  • My PR follows the style guidelines of this project
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

@cpg
Copy link
Member

cpg commented Jul 27, 2020 •
edited by ShresthPratapSingh
Loading

Great improvement. This is what I came across:

  • When repeat-one-song is in effect, I notice that the list of songs remains, but pressing on any son yields the currently playing song. UX wise, tapping on one song then hearing another is not good. OTOH, repeating the one song is logical. Perhaps tapping on one of the songs on what's next ought to play that and make that the repeat-one-song track! Easy?
  • When repeat-one-song is in effect, the image swiping effect does not finish. It leaves the artwork half way slid on the screen. Easy to fix?
  • The artwork aspect ratio is not preserved still.

@ShresthPratapSingh
Copy link
Contributor Author

@cpg please let me know the device you're using for testing so that I replicate the image aspect ratio issue on that.

@cpg
Copy link
Member

cpg commented Jul 30, 2020

It's a year old iphone x. i shared the song with you. please fix the conflicts, validate all is working.

@ShresthPratapSingh
Copy link
Contributor Author

@cpg I've implemented the suggested changes and resolved conflicts. This PR is ready to merge.

@cpg cpg merged commit 9313148 into amahi:beta Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ShresthPratapSingh @cpg