Music Crashes #310
Merged
Music Crashes #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to update this PR for video player also, So we can't merge this right now. I'll update this PR with the video player crash ASAP. |
|
@cpg please review this for Audio player and if everything is fine please merge this, I'll open new PR for video player crash issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request solved Audio player Crash issue.
Apple API docs state that functions with MPRemoteCommandEvent params should return MPRemoteCommandHandlerStatus. The current implementation has these as returning void, which is crashing apps using this plugin in iOS 13.
Issue(s) related
#289
Tested in iOS 13.4.1, iOS 11.1 and in iOS 12.0