(closes PR# 248)Singleton local storage #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify the declaration of a read-only computed property by removing get keyword - Fix incorrect import (Foundation is not enough to work with UIColor) - Fix an incorrect data type of the parameters (the previous implementation will not work correctly if UIColor's initializer with Int type parameters appears) - Correct the indents between operands
Add notes to ensure contributors do not push sensitive contents.
ShresthPratapSingh
changed the title
|
@cpg please have a look. |
cpg
reviewed
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A shared instance of LocalStorage class is used in the app in order to provide Global point access to its object. Since the init was still public anyone could create a new object of LocalStorage, killing the whole point of using a shared instance and this provides room for errors.
Making the init private ensures that creating new objects of this class is prohibited and you are compelled to use the shared instance.
This PR will close PR # 248(Changed LocalStorage(a singleton class) init to private)