Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptions in the walkthrough UI overlap in landscape orientation #353

Closed
anubhavpulkit opened this issue Aug 15, 2020 · 1 comment · Fixed by #361
Closed

Descriptions in the walkthrough UI overlap in landscape orientation #353

anubhavpulkit opened this issue Aug 15, 2020 · 1 comment · Fixed by #361

Comments

@anubhavpulkit
Copy link
Contributor

  • The description text in landscape orientation has overlapped the baseline.
  • The page controller action is not working. The Ui is not changing with the page controller.
  • Color of next button is black which look quite unordered.(*change to white or make skip and next button blue color)

Screenshots/ gif

  • Color of next button
    walkthrough1

  • Description text issue
    walkthrough

  • Page controller action
    walkthrough 2

@cpg cpg changed the title issue in Walkthrough Ui Issue in walkthrough UI Aug 17, 2020
@ShresthPratapSingh
Copy link
Contributor

To easily test Walkthrough Screen UI:

  • Go to SettingsViewController.Swift > internal func signOut()
  • In signOut() Comment out the following line of code
    let loginVc = self.viewController(viewControllerClass: LoginViewController.self, from: StoryBoardIdentifiers.main)
  • In place of the code we just commented add the following code:
    let loginVc = UIStoryboard(name: "Main", bundle: nil).instantiateViewController(withIdentifier: StoryBoardIdentifiers.walktrhoughViewController)
  • Build and run. When you sign-out from Settings tab, Walkthrough screen is presented hence no need to uninstall and reinstall the app everytime.

This code is purely meant to make testing easy and should NOT be commited.

@cpg cpg changed the title Issue in walkthrough UI Descriptions in the walkthrough UI overlap in landscape orientation Aug 24, 2020
@cpg cpg closed this as completed in #361 Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants