Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for parsing visibility and state mutability #682

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jun 25, 2024

Closes #681
Closes #389

@DaniPopes DaniPopes changed the title wip:feat: add support for state mutability parsing feat: add support for state mutability parsing Jun 27, 2024
@DaniPopes DaniPopes changed the title feat: add support for state mutability parsing feat: add support for parsing visibility and state mutability Jun 27, 2024
@DaniPopes DaniPopes marked this pull request as ready for review June 27, 2024 18:21
Copy link
Member Author

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate it boss 🫡

@0xfourzerofour
Copy link

0xfourzerofour commented Jun 27, 2024

thanks for the quick turnaround, this will be super helpful

@DaniPopes DaniPopes merged commit 56de57a into main Jun 27, 2024
30 checks passed
@DaniPopes DaniPopes deleted the matt/wip-state-mutability branch June 27, 2024 22:37
klkvr pushed a commit that referenced this pull request Aug 4, 2024
* feat: add support for state mutability parsing

* feat: finish the implementation

* docs

* doc

* more tests

* features

---------

Co-authored-by: DaniPopes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbiItem parsing from human readable ABI does not allow for state mutibility keywords [Feature] Full function signature parsing
3 participants