Skip to content

EIP-712 compatible Serializable impl for dyn_abi::eip712::TypedData #334

@edef1c

Description

@edef1c

Component

dyn-abi

Describe the feature you would like

TypedData seems to go to some effort to specifically name the types field resolver instead, taking pains to have a custom Deserializer impl that renames the field from types to resolver through an intermediate TypedDataHelper struct. There is no corresponding remapping for serialisation, and so the Serialize output is incompatible with both the Deserialize impl and EIP-712.

It's unclear to me why the field is named resolver to begin with, and it seems like it would save a bunch of hassle to just rename the field or at least mark it #[serde(rename = "types")].

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions