refactor: Lifetimes for token types #120

prestwich · 2023-06-19T17:27:45Z

Motivation

Prevent multiple copies of data in the data -> token -> encoding and decoding -> token -> data flows

Start introducing token lifetimes to allow tokens to borrow data from decoder or fro rust types

crates/sol-types/src/coder/token.rs

crates/sol-types/src/coder/encoder.rs

crates/sol-types/src/types/event/topic_list.rs

crates/sol-types/src/types/struct.rs

crates/sol-types/tests/doc_events.rs

prestwich added the enhancement New feature or request label Jun 19, 2023

prestwich self-assigned this Jun 19, 2023

prestwich changed the title ~~[WIP] refactor preview: Lifetimes for token types~~ refactor: Lifetimes for token types Jun 19, 2023

prestwich marked this pull request as ready for review June 19, 2023 21:51

prestwich requested a review from DaniPopes as a code owner June 19, 2023 21:51

prestwich mentioned this pull request Jun 20, 2023

feat: add Encodable trait #121

Merged

3 tasks

prestwich added 4 commits June 20, 2023 08:43

feature: lifetime for packedseqtoken

7431bf4

chore: clippy fix

f8d21ff

fix: update macro and fix tests

c778e95

nits: Copy and de

080e0d8

prestwich force-pushed the prestwich/token-lifetimes branch from 7eaffcb to 080e0d8 Compare June 20, 2023 15:45

DaniPopes requested changes Jun 20, 2023

View reviewed changes

prestwich added 3 commits June 20, 2023 10:30

fix: remove leftover code

4d0f9f4

docs: expand tokentype docs

c462431

fix: 'dede to 'de

128510f

prestwich enabled auto-merge (squash) June 20, 2023 18:20

DaniPopes approved these changes Jun 20, 2023

View reviewed changes

prestwich merged commit d480d99 into main Jun 20, 2023

DaniPopes deleted the prestwich/token-lifetimes branch June 20, 2023 18:34