feature: compute encoded size statically where possible #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures due to some sort of docker issue |
prestwich
force-pushed
the
prestwich/encoded-size
branch
from
655779e to
5351591
Compare
DaniPopes
requested changes
Jun 13, 2023
DaniPopes
requested changes
Jun 13, 2023
DaniPopes
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
for most types, encoded size is known at compile time.
Solution
add
pub ENCODED_SIZE: Option<usize>add
fn encoded_size<B>(rust: B)for run-time calculationPR Checklist