Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Generic" Feature Type #1598

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add "Generic" Feature Type #1598

wants to merge 4 commits into from

Conversation

mh0g
Copy link
Contributor

@mh0g mh0g commented Nov 16, 2023

Description

Added a 'generic' feature type for importing features that are not computed by alicevision.

For now the descriptor size is set to 128, but may be extended and padded with 0 to support wider descriptors in the future.

@mh0g mh0g self-assigned this Nov 16, 2023
@cbentejac cbentejac added this to the 3.3.0 milestone Nov 16, 2023
@mh0g mh0g marked this pull request as draft November 29, 2023 14:08
@mh0g mh0g marked this pull request as ready for review May 21, 2024 07:04
@natowi
Copy link
Member

natowi commented May 21, 2024

Why not call it "Custom Feature Type"?

@fabiencastan
Copy link
Member

@mh0g Could you rebase, to avoid merge nodes in the PR?

@fabiencastan
Copy link
Member

Or "Generic128" ?

@MrClock8163
Copy link

Can I ask why you chose to limit it to 128?

@fabiencastan
Copy link
Member

How would you do to get something fully dynamic?

@MrClock8163
Copy link

MrClock8163 commented May 25, 2024

I meant the question as in, why limit it to such a low number to begin with? I understand that there has to be a limit, but why 128?
Granted, 128 is probably more than enough for control points, but if someone would want to import en-masse matches, that would be impossible this way.

@fabiencastan
Copy link
Member

128 is for the memory size of each descriptor, not for the number of features/matches.

@MrClock8163
Copy link

I see. I suppose I misunderstood then. Figured this would work the same way as the CCTAG and AprilTag marker describers, where each match is a 128 bytes block, and FF byte in the block identifies the marker ID, which limits it to 128 different markers.
Sorry for the confusion.

@mh0g mh0g force-pushed the dev/unknownFeatureType branch from 67ae0ed to 0814510 Compare May 27, 2024 07:16
@mh0g mh0g force-pushed the dev/unknownFeatureType branch from 24434a9 to 2aba86f Compare September 4, 2024 12:51
@fabiencastan fabiencastan changed the title Unknown Feature Type Add "Generic" Feature Type Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants