-
-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Generic" Feature Type #1598
base: develop
Are you sure you want to change the base?
Conversation
Why not call it "Custom Feature Type"? |
@mh0g Could you rebase, to avoid merge nodes in the PR? |
Or "Generic128" ? |
Can I ask why you chose to limit it to 128? |
How would you do to get something fully dynamic? |
I meant the question as in, why limit it to such a low number to begin with? I understand that there has to be a limit, but why 128? |
128 is for the memory size of each descriptor, not for the number of features/matches. |
I see. I suppose I misunderstood then. Figured this would work the same way as the CCTAG and AprilTag marker describers, where each match is a 128 bytes block, and FF byte in the block identifies the marker ID, which limits it to 128 different markers. |
67ae0ed
to
0814510
Compare
0814510
to
e9a4be5
Compare
24434a9
to
2aba86f
Compare
Description
Added a 'generic' feature type for importing features that are not computed by alicevision.
For now the descriptor size is set to 128, but may be extended and padded with 0 to support wider descriptors in the future.