Handle errors

nickbar01234 · nickbar01234 · commit 98c2bab35770 · 2025-11-25T18:26:54.000-05:00
diff --git a/src/Controllers/fetchUserDetails.ts b/src/Controllers/fetchUserDetails.ts
@@ -36,7 +36,7 @@ const fetchUserDetails = async <T, U>(
     return res.json(formatData(result.data));
   } catch (err) {
     console.error('Error: ', err);
-    return res.send(err);
+    return res.send(err.message);
   }
 };
 
diff --git a/src/FormatUtils/formatter.ts b/src/FormatUtils/formatter.ts
@@ -2,5 +2,10 @@ import { ZodType } from 'zod';
 
 export const withSchema =
   <T, U>(schema: ZodType<T>, formatter: (data: T) => U) =>
-  (input: T) =>
-    formatter(schema.parse(input));
+  (input: T) => {
+    const result = schema.safeParse(input);
+    if (result.success) {
+      return formatter(result.data);
+    }
+    throw new Error(result.error.message);
+  };
diff --git a/src/schema/common/index.ts b/src/schema/common/index.ts
@@ -2,5 +2,5 @@ import z from 'zod';
 
 export const badge = z.object({
   name: z.string(),
-  icon: z.string(),
+  icon: z.string().optional(),
 });
diff --git a/src/schema/contests.ts b/src/schema/contests.ts
@@ -3,7 +3,7 @@ import { badge } from './common';
 
 const userContestRanking = z.object({
   attendedContestsCount: z.number().nonnegative(),
-  badge,
+  badge: badge.nullable(),
   globalRanking: z.number().nonnegative(),
   rating: z.number().nonnegative(),
   totalParticipants: z.number().nonnegative(),
@@ -20,7 +20,7 @@ const userContestRankingHistory = z.object({
   finishTimeInSeconds: z.number().nonnegative(),
   contest: z.object({
     title: z.string(),
-    startTime: z.string(),
+    startTime: z.number(),
   }),
 });
 

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ const fetchUserDetails = async <T, U>(`
`36`	`36`	`return res.json(formatData(result.data));`
`37`	`37`	`} catch (err) {`
`38`	`38`	`console.error('Error: ', err);`
`39`		`- return res.send(err);`
	`39`	`+ return res.send(err.message);`
`40`	`40`	`}`
`41`	`41`	`};`
`42`	`42`