Pause menu enhancements #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e as SubMenu item
…dded option for fixed texture ratio
…enu to return to previously selected item
pnwparksfan
force-pushed
the
pause-menu-enhancements
branch
from
afc9c98 to
799dae1
Compare
alexguirre
reviewed
Mar 6, 2022
- Dynamic tab size - Skippable tabs - Scrolling tab list
|
As per PNWParksFan's request, I'm leaving this screenshot in the discussion for this PR.
|
…with UpdateVisitbleItemsIndices when max<min, other cleanup
…nSelectItem has nothing selected (-1)
|
@alexguirre do you think there should be different formatting for background color and foreground color on skipped items (in menus or tabs), like there is for disabled items on menus? And if so, should that formatting apply automatically or be optional? I added some default formatting to gray out skipped tabs in a TabView, but noticed that in a UIMenu a Skipped element isn't formatted different currently. It might be confusing to users to have a tab or menu item they can't select with no visual indicator.
|
…items, fixed issue when changing background effect value while tabview is enabled
Item 2 resolved with d3976e3 |
…when game is paused
…focus level was mismatched
alexguirre
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to
TabMissionSelectItem:Draw()function to render correctly as a submenu itemImprovements to
TabSubmenuItem:Focusedproperty of the sub menu would remaintruebut theFocusLevelwould be out of sync, making it impossible to back out of that submenu.