Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization.DoesTextExist/GetText partially broken in b2372 #130

Closed
alexguirre opened this issue Jul 23, 2021 · 0 comments · Fixed by #131
Closed

Localization.DoesTextExist/GetText partially broken in b2372 #130

alexguirre opened this issue Jul 23, 2021 · 0 comments · Fixed by #131
Labels
Bug
Milestone
1.8.1

Comments

@alexguirre
Copy link
Owner

alexguirre commented Jul 23, 2021 •
edited
Loading

Returns false/NULL even if the label exists and _GET_LABEL_TEXT (0x7B5280EBA9840C72) returns the correct string. Seems like something changed in CTextFile.GetStringByHash.
@alexguirre alexguirre added the Bug label Jul 23, 2021
alexguirre added a commit that referenced this issue Jul 23, 2021
@alexguirre
(#130) Fix offset of CTextFile.OverridesTextMap
5e1aebf 
On b2372 a new slot for additional text was added which shifted some members of CTextFile, so offset 0x258 was the main text map instead of OverridesTextMap. This somehow caused the call to CTextFile.GetStringByHash to return NULL, at least in the example code.

Now the OverridesTextMap offset is found with a pattern at startup.
@alexguirre alexguirre mentioned this issue Jul 23, 2021
Merged
@alexguirre alexguirre added this to the 1.8.1 milestone Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.8.1
Development

Successfully merging a pull request may close this issue.

Fix Localization issues introduced in b2372 alexguirre/RAGENativeUI
1 participant
@alexguirre