fix: allow using findComponent on a functional component (#1593)

dobromir-hristov · web-flow · commit 2d6b49780c7e · 2020-07-04T10:27:01.000+10:00
diff --git a/packages/test-utils/src/wrapper.js b/packages/test-utils/src/wrapper.js
@@ -237,7 +237,7 @@ export default class Wrapper implements BaseWrapper {
    */
   findComponent(rawSelector: Selector): Wrapper | ErrorWrapper {
     const selector = getSelector(rawSelector, 'findComponent')
-    if (!this.vm) {
+    if (!this.vm && !this.isFunctionalComponent) {
       throwError(
         'You cannot chain findComponent off a DOM element. It can only be used on Vue Components.'
       )
diff --git a/test/specs/wrapper/find.spec.js b/test/specs/wrapper/find.spec.js
@@ -162,6 +162,18 @@ describeWithShallowAndMount('find', mountingMethod => {
       .with.property('message', message)
   })
 
+  it('allows using findComponent on functional component', () => {
+    const FuncComponentWithChildren = {
+      functional: true,
+      components: {
+        ChildComponent: Component
+      },
+      render: h => h('div', {}, [h(Component)])
+    }
+    const wrapper = mountingMethod(FuncComponentWithChildren)
+    expect(wrapper.findComponent(Component).exists()).to.be.true
+  })
+
   itSkipIf(isRunningPhantomJS, 'returns Wrapper of class component', () => {
     const TestComponent = {
       template: `

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ export default class Wrapper implements BaseWrapper {`
`237`	`237`	`*/`
`238`	`238`	`findComponent(rawSelector: Selector): Wrapper \| ErrorWrapper {`
`239`	`239`	`const selector = getSelector(rawSelector, 'findComponent')`
`240`		`- if (!this.vm) {`
	`240`	`+ if (!this.vm && !this.isFunctionalComponent) {`
`241`	`241`	`throwError(`
`242`	`242`	`'You cannot chain findComponent off a DOM element. It can only be used on Vue Components.'`
`243`	`243`	`)`