VLCFavoriteListViewController: Fix the search bar when the view is scrolled

Diogo Simao Marques · fkuehne · commit d1700caa2b5f · 2024-09-15T11:09:07.000Z
The search bar is now properly handled when the view is scrolled:
- The search is hidden when the text field is empty
- The search bar remains on the screen if the user is currently searching
diff --git a/Sources/Network/Favorite/iOS/VLCFavoriteListViewController.swift b/Sources/Network/Favorite/iOS/VLCFavoriteListViewController.swift
@@ -307,11 +307,24 @@ extension VLCFavoriteListViewController: UISearchBarDelegate {
 
 extension VLCFavoriteListViewController: UIScrollViewDelegate {
     func scrollViewDidScroll(_ scrollView: UIScrollView) {
+        // This ensures that the search bar is always visible like a sticky while searching
+        if isSearching {
+            searchBar.endEditing(true)
+            if let searchBarText = searchBar.text,
+               searchBarText.isEmpty {
+                searchBarCancelButtonClicked(searchBar)
+            }
+            return
+        }
+
         searchBarConstraint?.constant = -min(scrollView.contentOffset.y, searchBarSize) - searchBarSize
-        view.layoutIfNeeded()
         if scrollView.contentOffset.y < -searchBarSize && scrollView.contentInset.top != searchBarSize {
             tableView.contentInset.top = searchBarSize
         }
+
+        if scrollView.contentOffset.y >= 0 && scrollView.contentInset.top != 0 {
+            tableView.contentInset.top = 0
+        }
     }
 }
 
