FavoriteListViewController: Remove unnecessary extension

Diogo Simao Marques · fkuehne · commit 6c1266e5919f · 2024-09-15T11:09:07.000Z
The UITableView class already inherits from the UIScrollView one.
diff --git a/Sources/Network/Favorite/iOS/FavoriteListViewController.swift b/Sources/Network/Favorite/iOS/FavoriteListViewController.swift
@@ -270,6 +270,27 @@ extension FavoriteListViewController: UITableViewDelegate, UITableViewDataSource
             self.showEmptyViewIfNeeded()
         }
     }
+
+    func scrollViewDidScroll(_ scrollView: UIScrollView) {
+        // This ensures that the search bar is always visible like a sticky while searching
+        if isSearching {
+            searchBar.endEditing(true)
+            if let searchBarText = searchBar.text,
+               searchBarText.isEmpty {
+                searchBarCancelButtonClicked(searchBar)
+            }
+            return
+        }
+
+        searchBarConstraint?.constant = -min(scrollView.contentOffset.y, searchBarSize) - searchBarSize
+        if scrollView.contentOffset.y < -searchBarSize && scrollView.contentInset.top != searchBarSize {
+            tableView.contentInset.top = searchBarSize
+        }
+
+        if scrollView.contentOffset.y >= 0 && scrollView.contentInset.top != 0 {
+            tableView.contentInset.top = 0
+        }
+    }
 }
 
 extension FavoriteListViewController: FavoriteSectionHeaderDelegate {
@@ -304,29 +325,6 @@ extension FavoriteListViewController: UISearchBarDelegate {
     }
 }
 
-extension FavoriteListViewController: UIScrollViewDelegate {
-    func scrollViewDidScroll(_ scrollView: UIScrollView) {
-        // This ensures that the search bar is always visible like a sticky while searching
-        if isSearching {
-            searchBar.endEditing(true)
-            if let searchBarText = searchBar.text,
-               searchBarText.isEmpty {
-                searchBarCancelButtonClicked(searchBar)
-            }
-            return
-        }
-
-        searchBarConstraint?.constant = -min(scrollView.contentOffset.y, searchBarSize) - searchBarSize
-        if scrollView.contentOffset.y < -searchBarSize && scrollView.contentInset.top != searchBarSize {
-            tableView.contentInset.top = searchBarSize
-        }
-
-        if scrollView.contentOffset.y >= 0 && scrollView.contentInset.top != 0 {
-            tableView.contentInset.top = 0
-        }
-    }
-}
-
 extension FavoriteListViewController {
     private func showCloudFavVC(fav: VLCFavorite) {
         let favURL = fav.url
