VideoPlayerViewController: Reduce the number of updateInterface calls

Diogo Simao Marques · Diogo Simao Marques · commit 68e8cf256e76 · 2024-10-09T17:07:33.000+02:00
The updateAudioInterface calls were being made too many times, including
during the phase of preparation of the playback leading to applying
constraints of the videoOutputView on views that were not properly
instanciated yet.

It was causing some glitches on the interface.
diff --git a/Sources/Playback/Player/VideoPlayer-iOS/VideoPlayerViewController.swift b/Sources/Playback/Player/VideoPlayer-iOS/VideoPlayerViewController.swift
@@ -1740,9 +1740,6 @@ extension VideoPlayerViewController: VLCPlaybackServiceDelegate {
         mediaNavigationBar.setMediaTitleLabelText("")
         videoPlayerControls.updatePlayPauseButton(toState: playbackService.isPlaying)
 
-        DispatchQueue.main.async {
-            self.updateAudioInterface(with: playbackService.metadata)
-        }
         // FIXME: -
         resetIdleTimer()
     }
@@ -1786,6 +1783,7 @@ extension VideoPlayerViewController: VLCPlaybackServiceDelegate {
         moreOptionsActionSheet.currentMediaHasChapters = currentMediaHasChapters
 
         if currentState == .opening {
+            updateAudioInterface(with: playbackService.metadata)
             applyCustomEqualizerProfileIfNeeded()
         }
 
@@ -1823,8 +1821,6 @@ extension VideoPlayerViewController: VLCPlaybackServiceDelegate {
             self.externalVideoOutputView.isHidden = true
         }
 
-        updateAudioInterface(with: metadata)
-
         videoPlayerButtons()
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1740,9 +1740,6 @@ extension VideoPlayerViewController: VLCPlaybackServiceDelegate {`
`1740`	`1740`	`mediaNavigationBar.setMediaTitleLabelText("")`
`1741`	`1741`	`videoPlayerControls.updatePlayPauseButton(toState: playbackService.isPlaying)`
`1742`	`1742`
`1743`		`- DispatchQueue.main.async {`
`1744`		`- self.updateAudioInterface(with: playbackService.metadata)`
`1745`		`- }`
`1746`	`1743`	`// FIXME: -`
`1747`	`1744`	`resetIdleTimer()`
`1748`	`1745`	`}`
`@@ -1786,6 +1783,7 @@ extension VideoPlayerViewController: VLCPlaybackServiceDelegate {`
`1786`	`1783`	`moreOptionsActionSheet.currentMediaHasChapters = currentMediaHasChapters`
`1787`	`1784`
`1788`	`1785`	`if currentState == .opening {`
	`1786`	`+ updateAudioInterface(with: playbackService.metadata)`
`1789`	`1787`	`applyCustomEqualizerProfileIfNeeded()`
`1790`	`1788`	`}`
`1791`	`1789`
`@@ -1823,8 +1821,6 @@ extension VideoPlayerViewController: VLCPlaybackServiceDelegate {`
`1823`	`1821`	`self.externalVideoOutputView.isHidden = true`
`1824`	`1822`	`}`
`1825`	`1823`
`1826`		`- updateAudioInterface(with: metadata)`
`1827`		`-`
`1828`	`1824`	`videoPlayerButtons()`
`1829`	`1825`	`}`
`1830`	`1826`