Skip to content

Reject submissions for segments beyond the video's end #2137

Open
@JTBrinkmann

Description

@JTBrinkmann

I have just noticed a video with a segment that is far beyond the video's duration. This surprised me, as segments submissions also contain the video's duration, meaning such submissions could be filtered server-side. In my opinion, this is a minor issue.

For clarification: i suggest to only reject submissions, whose segement is beyond the duration mentioned in the same submission.

Example video: https://www.youtube.com/watch?v=w0R1jVN3LaY
The video is 6:21 long, yet the segment in question is 12:18 - 13:19 (though the very same segment data says the video's duration is 6:21).
The API's response:

[
  ...,
  {
    "videoID": "w0R1jVN3LaY",
    "segments": [
      ...
      {
        "category": "sponsor",
        "actionType": "skip",
        "segment": [
          748.002,
          799.149
        ],
        "UUID": "cc3fe74021e90c8ff39d10a531b791261af57c2199f2af7f733cce04aeb8dc0b7",
        "videoDuration": 381,
        "locked": 0,
        "votes": -1,
        "description": ""
      }
    ]
  },
  ...
]

I tested this with the Firefox addon and SmartTube. The addon shows the segment in the "popout" next to the video, however it's not visible in the seekbar. On SmartTube there is a minor visual artifact as the segment is shown beyond the usual seekbar's end. I did not analyse how such a submission could have been submitted in the first place.

I did not find any existing issue for this, I searched for open/closed tickets with "duration" and "beyond end"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions