Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: classname does not exists in src/components/ui/dialog.tsx and .../ui/alert-dialog.tsx #17

Open
dacmarcell opened this issue May 5, 2024 · 3 comments
Open

fix: classname does not exists in src/components/ui/dialog.tsx and .../ui/alert-dialog.tsx #17

dacmarcell opened this issue May 5, 2024 · 3 comments

Comments

@dacmarcell
Copy link

How to reproduce?

Command: npm create tauri-ui

-> Next.js

Command: npm install && npm run build

Output:

> npm run build

> [email protected] build
> next build

 ✓ Creating an optimized production build
 ✓ Compiled successfully
   Linting and checking validity of types  .Failed to compile.

./src/components/ui/dialog.tsx:14:3
Type error: Property 'className' does not exist on type 'DialogPortalProps'.

Merge branch 'main' of https://github.com/marcelldac/tauri-ui
  12 |
  13 | const DialogPortal = ({
> 14 |   className,
     |   ^
  15 |   ...props
  16 | }: DialogPrimitive.DialogPortalProps) => (
  17 |   <DialogPrimitive.Portal className={cn(className)} {...props} />

I just deleted classname of this errors

How do i make this works?
@AldonahZero
Copy link

Will removing the classname directly have any impact?

@dacmarcell
Copy link
Author

If I run the application, it returns this error.

@matherriot
Copy link

Can be fixed by updating the shadcn/ui component.
pnpm dlx shadcn-ui@latest add alert-dialog for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AldonahZero @dacmarcell @matherriot