Box V1 #8
Merged
Box V1 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timelessco/renderlesskit-react-tailwind/9ntmygekn |
anuraghazra
reviewed
Dec 15, 2020
|
|
||
| const _viewBox = viewBox ?? fallbackIcon.viewBox; | ||
| const shared: any = { |
There was a problem hiding this comment.
removing any does not seem to affect anything so let's remove it.
anuraghazra
approved these changes
Dec 15, 2020
navin-moorthy
added a commit
that referenced
this pull request
Dec 15, 2020
* feat(button): ✨ add button size variant based on figma design * fix(button): 🐛 button issue passing children * feat(icon): ✨ add icon support for button * feat(button): ✨ add left & right icon with icons stories * feat(spinner): ✨ add spinner & integrate with button * build(deps): 💚 fix build by localizing & upgrading deps * Box V1 (#8) * feat(box): ✨ add box primitive component * fix(box): 🏷️ fix box type issue with as * fix(components): 🐛 add as functionality to all components
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.