-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tag component #12
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timelessco/renderlesskit-react-tailwind/j8qeyfn87 |
Allow styling default close icon 🤔 |
If they want to style the default close icon they can provide their own close icon that's the idea here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Tag Component
References:
Ant Design : https://ant.design/components/tag
Vercel: https://vercel.com/design/tag
UI Patterns: http://ui-patterns.com/patterns/Tag
Although Tag component looks same as our Button component with icons on both sides and content. Use cases and the API can be a bit different since Tag is a closable/removable item.
When to use:
Props
<CloseIcon />
By default Tag component will have x close icon in the suffix if the closable prop is true.
API
Change suffix icon
TagGroup
Reference: https://vercel.com/design/tag
We can also add a TagGroup component to handle the keyboard logic for the multiple tags
Ideally TagGroup will be a composite which would allows users to navigate the tags icons with ArrowLeft/Right
Note: The state logic for removing/adding the tags will be handled by the user not us.
Props