feat(button): ✨ add button group #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timelessco/renderlesskit-react-tailwind/9leac96kt |
navin-moorthy
commented
Dec 16, 2020
| @@ -1,3 +1,4 @@ | |||
| import * as React from "react"; | |||
Contributor
Author
There was a problem hiding this comment.
Using our package in a test app requires the react import.
navin-moorthy
commented
Dec 16, 2020
| import { overrideTailwindClasses } from "tailwind-override"; | ||
|
|
||
| import tailwindProperties from "../../tailwindProperties.json"; | ||
| import { tailwindProperties } from "./tailwindProperties"; |
Contributor
Author
There was a problem hiding this comment.
These properties should be part of the build inorder to utilize them.
navin-moorthy
changed the title
anuraghazra
reviewed
Dec 17, 2020
anuraghazra
reviewed
Dec 17, 2020
anuraghazra
approved these changes
Dec 17, 2020
Contributor
|
LGTM! |
navin-moorthy
added a commit
that referenced
this pull request
Dec 17, 2020
* feat(button): ✨ add variant support for button * fix(button): 🐛 add current color to button spinner * feat(button): ✨ add button group (#11) * fix(build): 🐛 fix code to support the build version * feat(buttongroup): ✨ add button group & fix button disabled issues * fix(buttonicon): 🐛 add aria-label & stories for button-group * feat(button): ✨ add new example using reakit tab * fix(button): 🐛 left & right icon to prefix & suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.