Skip to content

Commit f157205

Browse files
committed
[scripts] self documenting refactoring in bin/ycsb
1 parent b92c573 commit f157205

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

bin/ycsb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,12 @@ def is_distribution():
138138
# presumes maven can run, so should only be run on source checkouts
139139
# will invoke the 'package' goal for the given binding in order to resolve intra-project deps
140140
# presumes maven properly handles system-specific path separators
141-
def get_classpath_from_maven(database):
141+
# Given module is full module name eg. 'core' or 'couchbase-binding'
142+
def get_classpath_from_maven(module):
142143
try:
143-
debug("Running 'mvn -pl com.yahoo.ycsb:"+database+" -am package -DskipTests "
144+
debug("Running 'mvn -pl com.yahoo.ycsb:" + module + " -am package -DskipTests "
144145
"dependency:build-classpath -DincludeScope=compile -Dmdep.outputFilterFile=true'")
145-
mvn_output = subprocess.check_output(["mvn", "-pl", "com.yahoo.ycsb:" + database,
146+
mvn_output = subprocess.check_output(["mvn", "-pl", "com.yahoo.ycsb:" + module,
146147
"-am", "package", "-DskipTests",
147148
"dependency:build-classpath",
148149
"-DincludeScope=compile",

0 commit comments

Comments
 (0)