Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: region, bins, healpix, ztffields #52

Open
MickaelRigault opened this issue Aug 1, 2022 · 9 comments
Open

v2: region, bins, healpix, ztffields #52

MickaelRigault opened this issue Aug 1, 2022 · 9 comments
Assignees
Labels

Comments

@MickaelRigault
Copy link
Member

Hi @mcoughlin you mentioned you wanted to use astropy regions,
this is what you had in mind right ?

https://astropy-regions.readthedocs.io/en/stable/

@mcoughlin
Copy link
Contributor

@MickaelRigault Yup! We have some example interactions coded up here: https://github.com/skyportal/skyportal/blob/main/skyportal/handlers/api/instrument.py#L519
too.

@MickaelRigault MickaelRigault changed the title v2 region, bins, healpix, ztffields v2: region, bins, healpix, ztffields Aug 1, 2022
@MickaelRigault
Copy link
Member Author

This seems close to shapely:
https://shapely.readthedocs.io/en/stable/manual.html
Which is a very powerful tool coupled with pandas inside geopandas (and super fast).

I'll have a closer look.

@MickaelRigault
Copy link
Member Author

@mcoughlin
Copy link
Contributor

@MickaelRigault Indeed. To me, the important thing is interactions with the healpix stuff.

@MickaelRigault
Copy link
Member Author

do you have an example of that too (never used it before)

@mcoughlin
Copy link
Contributor

@MickaelRigault healpy has nice utility functions for extracting indices from shapes: https://healpy.readthedocs.io/en/latest/generated/healpy.query_polygon.html
@lpsinger has nice utility functions too in ligo.skymap: https://git.ligo.org/lscsoft/ligo.skymap/-/tree/main/ligo/skymap/tool
depending on what exactly is needed. He also made an overlap calculator for doing the overlaps in postgres directly: https://github.com/skyportal/healpix-alchemy which has nice examples too.

@MickaelRigault
Copy link
Member Author

@mcoughlin
For simplicity, I have move the implementation of the refreshed simsurvey here:
https://github.com/MickaelRigault/skysurvey

I currently call it skysurvey, we can easily merge it with simsurvey if we want to keep the simsurvey "brand".

Moving the discussion above there.

You will see basic implementation started.

@mcoughlin
Copy link
Contributor

Really interesting @MickaelRigault! Personally I think that yes this should become the new simsurvey. Presumably the tag should be a 1.X release to indicate potentially breaking changes once it is ready.

@MickaelRigault
Copy link
Member Author

Fine by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants