Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: YusukeIwaki/puppeteer-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.35.1
Choose a base ref
...
head repository: YusukeIwaki/puppeteer-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.36.0
Choose a head ref
  • 20 commits
  • 23 files changed
  • 3 contributors

Commits on Aug 12, 2021

  1. Update rubocop requirement from ~> 1.18.0 to ~> 1.19.0 

    Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.18.0...v1.19.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Aug 12, 2021
    Configuration menu
    Copy the full SHA
    2dec7dc View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. Update RuboCop to 1.19.0 used in Reviewdog

    @YusukeIwaki
    YusukeIwaki committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    9df4120 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #132 from YusukeIwaki/dependabot/bundler/rubocop-t… 

    …w-1.19.0

Update rubocop requirement from ~> 1.18.0 to ~> 1.19.0
    Yusuke Iwaki authored Aug 14, 2021
    Configuration menu
    Copy the full SHA
    945f5f2 View commit details
    Browse the repository at this point in the history

  3. Improve define_async_method. 

    The block call of wait_for_xxx should be evaluated after wait_for_xxx.
Concurrent::Promises.zip(promises) don't ensure the order of evaluation of promises.

```
async_xxxx = Concurrent::Promises.future { ... } # start evaluating here.
async_calling_block = Concurrent::Promises.delay { ... } # not evaluated here.

Concurrent::Promises.zip(
  async_xxx,
  axync_calling_block,
).value! # async_calling_block starts to be evaluated here.
```
    @YusukeIwaki
    YusukeIwaki committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    2162767 View commit details
    Browse the repository at this point in the history

  4. unskip user_data_dir spec on Firefox

    @YusukeIwaki
    YusukeIwaki committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    25593fa View commit details
    Browse the repository at this point in the history

  5. Merge pull request #133 from YusukeIwaki/improve_define_async_method 

    Improve define_async_method.
    Yusuke Iwaki authored Aug 14, 2021
    Configuration menu
    Copy the full SHA
    0802586 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Update API coverage

    @YusukeIwaki
    YusukeIwaki committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    7a0a3d7 View commit details
    Browse the repository at this point in the history

  2. Implement Page#emulate_cpu_throttling

    @YusukeIwaki
    YusukeIwaki committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    d1a4c67 View commit details
    Browse the repository at this point in the history

  3. Update API coverage

    @YusukeIwaki
    YusukeIwaki committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    baf5479 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #134 from YusukeIwaki/emulateCPUThrottling 

    Implement Page#emulate_cpu_throttling
    Yusuke Iwaki authored Aug 16, 2021
    Configuration menu
    Copy the full SHA
    b39c2bb View commit details
    Browse the repository at this point in the history

  5. add Page#emulateNetworkConditions

    @YusukeIwaki
    YusukeIwaki committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    afedc8a View commit details
    Browse the repository at this point in the history

  6. Update API coverages

    @YusukeIwaki
    YusukeIwaki committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    4ae54f0 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #135 from YusukeIwaki/emulateNetworkConditions 

    add Page#emulateNetworkConditions
    Yusuke Iwaki authored Aug 16, 2021
    Configuration menu
    Copy the full SHA
    6017dec View commit details
    Browse the repository at this point in the history

  8. Implement Page#expose_function

    @YusukeIwaki
    YusukeIwaki committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    9b73f10 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #136 from YusukeIwaki/exposeFunction 

    Implement Page#expose_function
    Yusuke Iwaki authored Aug 16, 2021
    Configuration menu
    Copy the full SHA
    c28f34f View commit details
    Browse the repository at this point in the history

  10. Implement Page#metrics

    @YusukeIwaki
    YusukeIwaki committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    87b0182 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Merge pull request #137 from YusukeIwaki/metrics

    Yusuke Iwaki authored Aug 17, 2021
    Configuration menu
    Copy the full SHA
    20aeaa9 View commit details
    Browse the repository at this point in the history

  2. Implement drag-and-drop

    @YusukeIwaki
    YusukeIwaki committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    20256e5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #138 from YusukeIwaki/drag_drop 

    Implement drag-and-drop
    Yusuke Iwaki authored Aug 17, 2021
    Configuration menu
    Copy the full SHA
    dd3aa4f View commit details
    Browse the repository at this point in the history

  4. 0.35.1 -> 0.36.0

    @YusukeIwaki
    YusukeIwaki committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    7970831 View commit details
    Browse the repository at this point in the history
Loading