Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: YusukeIwaki/puppeteer-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.0.18
Choose a base ref
...
head repository: YusukeIwaki/puppeteer-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.0.19
Choose a head ref
  • 20 commits
  • 27 files changed
  • 1 contributor

Commits on Aug 26, 2020

  1. add feature: keyboard with block

    @YusukeIwaki
    YusukeIwaki committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    c20bc76 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #18 from YusukeIwaki/keyboard_with_block 

    add feature: keyboard with block
    @YusukeIwaki
    YusukeIwaki authored Aug 26, 2020
    Configuration menu
    Copy the full SHA
    113cb93 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. add RSpec: query_selector_spec

    @YusukeIwaki
    YusukeIwaki committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    ac3ae9c View commit details
    Browse the repository at this point in the history

  2. bump RuboCop to 0.90.0

    @YusukeIwaki
    YusukeIwaki committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    b4d8e53 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #19 from YusukeIwaki/query_selector_spec 

    add RSpec: query_selector_spec
    @YusukeIwaki
    YusukeIwaki authored Sep 2, 2020
    Configuration menu
    Copy the full SHA
    0084d47 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #20 from YusukeIwaki/bump_rubocop_0.90 

    Bump rubocop 0.90
    @YusukeIwaki
    YusukeIwaki authored Sep 2, 2020
    Configuration menu
    Copy the full SHA
    fd177d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. add Firefox support

    @YusukeIwaki
    YusukeIwaki committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    bf718c1 View commit details
    Browse the repository at this point in the history

  2. Test firefox with CircleCI

    @YusukeIwaki
    YusukeIwaki committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    2fa71e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. define it_fails_firefox

    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    f1a9c05 View commit details
    Browse the repository at this point in the history

  2. Stop reusing a page instance across specs (only in Firefox).

    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    ab913c7 View commit details
    Browse the repository at this point in the history

  3. modify user-agent spec.

    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    defdd41 View commit details
    Browse the repository at this point in the history

  4. skip some specs, which is also skipped in Puppeteer's 

    hoge
    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    11efa67 View commit details
    Browse the repository at this point in the history

  5. fix keyboard_spec to pass.

    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    b8ad789 View commit details
    Browse the repository at this point in the history

  6. use Pending instead of Skip, for showing errors and avoiding unnecess… 

    …ary skip
    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    be2ea4b View commit details
    Browse the repository at this point in the history

  7. fix BoxModel for Firefox

    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    62b8821 View commit details
    Browse the repository at this point in the history

  8. distinguish PUPPETEER_PRODUCT, PUPPETEER_EXECUTABLE_PATH, that is onl… 

    …y used in RSpec, and that is not actually used in puppeteer-core
    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    bdadb63 View commit details
    Browse the repository at this point in the history

  9. replace useless it_fails_firefox with it

    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    1e2b377 View commit details
    Browse the repository at this point in the history

  10. Firefox for Linux shows scrollbars... so hide it!

    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    250fa92 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #21 from YusukeIwaki/firefox 

    add Firefox support
    @YusukeIwaki
    YusukeIwaki authored Sep 7, 2020
    Configuration menu
    Copy the full SHA
    2eaf12e View commit details
    Browse the repository at this point in the history

  12. 0.0.18 -> 0.0.19

    @YusukeIwaki
    YusukeIwaki committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    1c1170b View commit details
    Browse the repository at this point in the history
Loading