Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Integer to Buffer conversion not working #1915

Open
1 task
GarThor opened this issue Sep 21, 2024 · 4 comments
Open
1 task

[Bug] Integer to Buffer conversion not working #1915

GarThor opened this issue Sep 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@GarThor
Copy link

GarThor commented Sep 21, 2024

Operating System

Windows

What's the issue you encountered?

Using the Data Processor feature, if I create an "Integer to Buffer" node, and then route that to either a "Buffer to Integer" (and then an "Integer Display" node), or directly to a "Bits Display" node, both display nodes only display "???", where I would expect a number.

image

How can the issue be reproduced?

See "Issue"

o Go to Data Processor
o Add the following nodes

  • Integer to Buffer
  • Buffer to Integer
  • Integer Display
  • Bits Display
    o Route them so that "Integer to Buffer" connects to both "Buffer to Integer" and "Bits Display"
    o Route "Buffer to Integer" to "Integer Display"

ImHex Version

1.32.X@811214d

ImHex Build Type

  • Nightly or built from sources

Installation type

MSI

Additional context?

No response

@GarThor GarThor added the bug Something isn't working label Sep 21, 2024
@paxcut
Copy link
Contributor

paxcut commented Sep 21, 2024

why is the buffers size 32? thats 32 bytes. Buffer size 32 doesn't work because an integer can only be at most 16 bytes. If you try a number between 1 and 16 then it works

image

@paxcut
Copy link
Contributor

paxcut commented Sep 21, 2024

If you try to run it using 32 in size you should get result like this:

image

@GarThor
Copy link
Author

GarThor commented Sep 21, 2024

Odd, I didn't see the warning initially...

I assumed buffer size was in bits, which is why I specified 32 instead of 4. I thought I had tried smaller numbers, but it seems to be working as intended now.

@paxcut
Copy link
Contributor

paxcut commented Sep 21, 2024

I had the same problem at first. I typed 4 in the size field and nothing changed. Then I remembered that I didn't have continuous evaluation on so I had to press play to execute the code. When I typed 32 in the size again and pressed play I saw the warning.

Using bits for the size wouldn't make sense. You could type things like 12 or 7 but that wouldn't give you those number of bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants