Skip to content

Conversation

@adamPetho
Copy link
Contributor

@adamPetho adamPetho commented May 14, 2025

Fix: #13903

@adamPetho adamPetho marked this pull request as ready for review June 3, 2025 14:56
@adamPetho
Copy link
Contributor Author

I was about to give up on this, but I found a better solution.

@MarnixCroes @Kruwed could you please test if this fixes the issue on your OS as well? Ty.

Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11d4c3f

it fixes the issue,
but it also introduces the possibility to enter non BIP 39 words, like GitHub and when there is only 1 suggested word left -> pressing enter will not select it anymore but apply the written letters

@turbolay turbolay force-pushed the fix_recovery_word_typing_issue branch from 11d4c3f to 221a4ca Compare June 4, 2025 23:17
@turbolay
Copy link
Collaborator

turbolay commented Jun 4, 2025

This issue bubbles down to Avalonia's AutoCompleteBox or the way we use it (couldn't isolate one explanation)

AutoCompleteBox.SearchText property is not correctly updated when the Suggestions array contains the new text to be written.
So when I write o then f, AutoCompleteBox.SearchText will be equal to of.
But when I add another f, AutoCompleteBox.SearchText will still be equal to of, as Suggestions contains off

Because of this, trying to add subsequent letters doesn't work because we force the Text to always be part of Suggestions, but the text we try to write is ofi according to the component, which therefore doesn't allow it.

221a4ca is extremely dirty but it more or less works -> It uses reflection to check which part of the AutoCompleteBox is actually a text and which is the suggested part. If there is no suggested part, it overrides typedFullText with the full text, in my example offi

@turbolay turbolay merged commit bf000bb into WalletWasabi:master Jun 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't write the end of a word in Recovery when a full word is a substring

4 participants