Add button to copy TX hex to clipboard #13766
Conversation
maybe just an icon? without text. which then has a tooltip |
turbolay
left a comment
turbolay
left a comment
There was a problem hiding this comment.
Why are you rebuilding the transaction?
private async Task CopyTxHexAsync()
{
if(_transaction is null)
{
return;
}
var hex = _transaction.Transaction.Transaction.ToHex();
await UiContext.Clipboard.SetTextAsync(hex);
}Also the button is slightly misaligned
I also don't fancy so much the placement there. It's ok but.. meh. It would be much better next to the Confirm button. I now that it's not easy to do because the ContentArea doesn't cover this footer. We could merge with the button there and change later on
Maybe make the confirm button a subaction button? |
I don't like it either. How about adding |
Similar to the Transaction Details page then. Honestly, on the left of the Confirm button seems like the only good solution |
|
This feature also creates issues that are mentioned here: #13468 (comment) This PR ignores them. It is bad because when broadcasting yourself you will lose info about Labels |
What do you mean by "merge with the button there"?
Ah, I didn't know you already had a debate on this. Then, I guess this feature is stuck until that is solved or we decide to completely ignore it. |
I agree, and for the same reason it's bad to have a button on the left of the Confirm button that will be used only by 1% of users. If the use case is to use this to build a transaction but not broadcast it, then a better solution is to have it as an advanced feature by adding a separate button |
4 participants
Fixes: #13434