You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: apps/ui/README.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,7 +1,7 @@
1
1
***e2e tests execution***
2
2
3
3
1. Local setup
4
-
- install appium and all requirments related to `nativescript-dev-appium` plugin usage
4
+
- install appium and all requirements related to `nativescript-dev-appium` plugin usage
5
5
- download images:
6
6
7
7
```npm run load-images Emulator-Api23-Default "iPhone X 12"```
@@ -36,7 +36,7 @@
36
36
- Run:
37
37
38
38
`npm run e2e-debug [android|ios]`
39
-
run in separate console and don't kill it. This command will start appium server and driver and use the installed app on the device but it will not execute tests.
39
+
run in separate console and don't kill it. This command will start appium server and driver and use the installed app on the device, but it will not execute tests.
Copy file name to clipboardExpand all lines: tools/notes/CONTRIBUTING-webpack.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -23,7 +23,7 @@ Before starting, make yourself familiar with the `@nativescript/webpack`'s [docu
23
23
## Project Structure
24
24
25
25
The repository contains several ingredients:
26
-
*`installer.js` - combination of postinstall scripts for adding or removing webpack configurations and necessary dependecies when installing the plugin.
26
+
*`installer.js` - combination of postinstall scripts for adding or removing webpack configurations and necessary dependencies when installing the plugin.
27
27
*`templates/` - webpack config templates for different types of projects - NativeScript with JavaScript, NativeScript with TypeScript and NativeScript Angular projects.
28
28
*`plugins/` - several [Webpack plugins](https://webpack.js.org/concepts/plugins/) necessary for bundling NativeScript applications.
29
29
*`snapshot/android/` - tools used with the `NativeScriptSnapshot` plugin for generating V8 Heap Snapshots.
*** Note: If there are commits in release branch which are not merged in master branch '-ff-merge' command will fail.
167
-
In this case the commits should be merge firstly from release in master branch as explained in section 'Merge changes from release into master' and then repeat step 1.
167
+
In this case the commits should be merged firstly from release in master branch as explained in section 'Merge changes from release into master' and then repeat step 1.
168
168
169
169
2. Execute `npm i` to install dependencies:
170
170
```
@@ -233,7 +233,7 @@ git commit
233
233
git push
234
234
```
235
235
236
-
6. Create pull request. Replace replace env ${MERGE_BRANCH} with its value
236
+
6. Create pull request. Replace env ${MERGE_BRANCH} with its value
237
237
```
238
238
curl -d '{"title": "chore: merge release in master","body": "chore: merge release in master","head": "merge-release-in-master","base": "master"}' -X POST https://api.github.com/repos/NativeScript/NativeScript/pulls -H "Authorization: token ${GIT_TOKEN}"
Copy file name to clipboardExpand all lines: tools/notes/CONTRIBUTING.md
+6-6Lines changed: 6 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -94,12 +94,12 @@ When you click on the button, you will be redirected to the report page. On the
94
94
95
95
> Note: Each item name consists of the application name, type of device and platform version: `pr-e2e-tests-[application-name]-[device-type]-[platform-version]`. Usually, the test applications, that are executed for PRs are part of NativeScript repository.
96
96
97
-
Based on the executed suite, one of the following or all of the following files will be generated: `mochawesome.html` | `index.html` | `unit-tests.log`. Some of the reports also might include `*.png`, `*.logs` or `[page source].xml` files that can help in understanding where is the problem.
97
+
Based on the executed suite, one of the following or all of the following files will be generated: `mochawesome.html` | `index.html` | `unit-tests.log`. Some reports also might include `*.png`, `*.logs` or `[page source].xml` files that can help in understanding where is the problem.
98
98
99
99
For example:
100
100
1. When you select the `index.html` page, an additional `TestNG Results` sidebar will be displayed. There you can find a list of all failures.
101
101
2. When you select one of them, you will see on the right side all tests, that have been executed. The problematic ones will be coloured in red.
102
-
3. If you click on one of them, detailed info or error log will be displayed. As we've mentioned above in some of the test reports, you will also find screenshots, that demonstrates the problem visually. Those images can be found below the info/ error log.
102
+
3. If you click on one of them, detailed info or error log will be displayed. As we've mentioned above in some test reports, you will also find screenshots, that demonstrates the problem visually. Those images can be found below the info/ error log.
*** Note: If there are commits in release branch which are not merged in master branch '-ff-merge' command will fail.
251
-
In this case the commits should be merge firstly from release in master branch as explained in section 'Merge changes from release into master' and then repeat step 1.
251
+
In this case the commits should be merged firstly from release in master branch as explained in section 'Merge changes from release into master' and then repeat step 1.
252
252
253
253
2. Execute `npm i` to install dependencies:
254
254
```
@@ -277,7 +277,7 @@ npm --no-git-tag-version version [major|minor|patch] -m "release: cut the %s rel
277
277
cd ..
278
278
```
279
279
6. Set correct version of **tns-core-modules-widgets** in tns-core-modules/package.json.
280
-
Usually tns-core-modules-widgets should already have been released and we need to set the official version.
280
+
Usually tns-core-modules-widgets should already have been released, and we need to set the official version.
281
281
282
282
7. Create release-branch with change log
283
283
```
@@ -333,7 +333,7 @@ git commit
333
333
git push
334
334
```
335
335
336
-
6. Create pull request. Replace replace env ${MERGE_BRANCH} with its value
336
+
6. Create pull request. Replace env ${MERGE_BRANCH} with its value
337
337
```
338
338
curl -d '{"title": "chore: merge release in master","body": "chore: merge release in master","head": "merge-release-in-master","base": "master"}' -X POST https://api.github.com/repos/NativeScript/NativeScript/pulls -H "Authorization: token ${GIT_TOKEN}"
Copy file name to clipboardExpand all lines: tools/notes/CodingConvention.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -509,7 +509,7 @@ class Foo {
509
509
```
510
510
511
511
## TypeScript optional parameters
512
-
**Do not** use optional parameters in IMPLEMENTATION files. This is because the TS compiler generates additional array and populates its from the **arguments** object. Still, it is OK to use these in a definition file (as declarations ONLY).
512
+
**Do not** use optional parameters in IMPLEMENTATION files. This is because the TS compiler generates additional array and populates it from the **arguments** object. Still, it is OK to use these in a definition file (as declarations ONLY).
Copy file name to clipboardExpand all lines: tools/notes/HandlingErrors.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -10,7 +10,7 @@ The `tns-core-modules/trace` utility module provides a good way to streamline er
10
10
Here are the guidelines how to use this when contributing to core-modules or creating your own plugins.
11
11
12
12
### Use `trace.write()`
13
-
Use trace.write() with the appropriate type to log noncritical errors.
13
+
Use trace.write() with the appropriate type to log non-critical errors.
14
14
15
15
>Note: For the `error` message level all loggers will be notified unconditionally, for all other levels (`log`,`info`,`warn`), tracing should be enabled and the corresponding categories should be added.
16
16
@@ -21,7 +21,7 @@ Use the `error()` when an error has occurred which compromises the stability of
21
21
22
22
After calling `trace.error()` consider just returning from the function you are currently in without completing.
23
23
24
-
There are cases when code execution jumps between native code (ex. Android/iOS SDKs) and JavaScript trough callbacks. In those cases it is most difficult to determine if an error (ex. expected argument is `undefined` or current state of components is invalid) is critical or not. Although, it seems that error is unrecoverable, it might be the case that the callback is called when the app has gone to the background or trough activity/window that is not longer visible. So just reporting the error with `write()` or `error()` is a good option in such cases.
24
+
There are cases when code execution jumps between native code (ex. Android/iOS SDKs) and JavaScript trough callbacks. In those cases it is most difficult to determine if an error (ex. expected argument is `undefined` or current state of components is invalid) is critical or not. Although, it seems that error is unrecoverable, it might be the case that the callback is called when the app has gone to the background or trough activity/window that is no longer visible. So just reporting the error with `write()` or `error()` is a good option in such cases.
25
25
26
26
27
27
## Throw the Error directly in code
@@ -31,6 +31,6 @@ Avoid throwing errors directly, especially in code that is not directly called f
31
31
2. Obviously misused public APIs (ex. wrong arguments types) which developers will call directly.
32
32
33
33
## Clearing Legacy Code
34
-
Not all the code in the `tns-core-modules` might conform to this guide as it might be written before some of the improvements of the trace modules (ex. `error()`). If you came across to such code you can always [give us a PR](CONTRIBUTING.md) referencing [this issue](https://github.com/NativeScript/NativeScript/issues/5914).
34
+
Not all the code in the `tns-core-modules` might conform to this guide as it might be written before some improvements of the trace modules (ex. `error()`). If you came across to such code you can always [give us a PR](CONTRIBUTING.md) referencing [this issue](https://github.com/NativeScript/NativeScript/issues/5914).
0 commit comments