feat(data-point-service): run outputType before adding entry #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
output type if set, it must pass in order for the entry to be added to cache store fix ViacomInc#451
acatl
commented
Apr 15, 2020
| @@ -19,74 +19,72 @@ $ npm install data-point-cache | |||
|
|
|||
| Create a new DataPoint Service Object | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
truly sorry for all of these changes, it seems the file had not been ran via prettier before. my only change on this file is marked at the bottom of the file
acatl
commented
Apr 15, 2020
|
|
||
| In the case the revalidation fails the flag will be removed to allow a new revalidation to be triggered. | ||
|
|
||
| It is important to know that once the `staleWhileRevalidate` delta has also expired a background revalidation will no longer be triggered and cold lookup will be triggered instead. For this reason it is important to carefully set the cache settings to have a solid caching strategy. | ||
|
|
||
| ### Validation |
There was a problem hiding this comment.
this is the only part I added regarding this PR
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 139 139
Lines 1972 1978 +6
Branches 195 197 +2
=========================================
+ Hits 1972 1978 +6
Continue to review full report at Codecov.
|
acatl
requested review from
arik223,
csarnataro,
hayandrew,
jerryluna,
raingerber and
RamzesTheSecond
jerryluna
previously approved these changes
Apr 15, 2020
micheleriva
previously approved these changes
Apr 16, 2020
arik223
previously approved these changes
Apr 16, 2020
raingerber
reviewed
Apr 16, 2020
packages/data-point-service/examples/express-cache-schema-revalidation.js
Outdated
Show resolved
Hide resolved
raingerber
reviewed
Apr 16, 2020
packages/data-point-service/examples/express-cache-schema-revalidation.js
Outdated
Show resolved
Hide resolved
raingerber
reviewed
Apr 16, 2020
|
|
||
| const HelloWorld = DataPoint.Model("HelloWorld", { | ||
| value: (input, acc) => { | ||
| // const id = parseInt(acc.locals.query.id, 10); |
raingerber
reviewed
Apr 16, 2020
packages/data-point-service/examples/express-cache-schema-revalidation.js
Outdated
Show resolved
Hide resolved
raingerber
previously approved these changes
Apr 17, 2020
acatl
dismissed stale reviews from raingerber, arik223, micheleriva, and jerryluna
via
b03d0fe
micheleriva
approved these changes
Apr 20, 2020
raingerber
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
fixes #451
if
outputTypereducer is set, it must pass in order for the entry to be added to the cache store.Why:
See #451
How:
By running executing outputType reducer before adding the entry into the cache store.
Checklist: