Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 440 add typedefs #441

Merged
merged 10 commits into from
Oct 14, 2019
Merged

Feature/issue 440 add typedefs #441

merged 10 commits into from
Oct 14, 2019

Conversation

RamzesTheSecond
Copy link
Contributor

@RamzesTheSecond RamzesTheSecond commented Oct 10, 2019 •
edited
Loading

What:

Why:

How:

Checklist:

  • Has Breaking changes
  • Documentation
  • Tests
  • Ready to be merged
  • Added username to all-contributors list

Tomasz fertacz added 3 commits October 10, 2019 20:07
feat:
71c88ec 
add Accumulator typedef

440
feat:
495e799 
add Reducer, RDOMElement types, add @types/react
feat:
06510e8 
add RDOMObject, TransformExpression, ElementSpec
acatl
acatl reviewed Oct 10, 2019
View reviewed changes
packages/data-point/package.json Outdated
@@ -48,6 +48,7 @@
"lib/"
],
"dependencies": {
"@types/react": "^16.9.5",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? probably needs to be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

acatl
acatl reviewed Oct 10, 2019
View reviewed changes
packages/data-point/data-point.d.ts Outdated
interface Reducer {
}

interface RDOMElement {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not exists in data-point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

acatl
acatl requested changes Oct 10, 2019
View reviewed changes
Copy link
Collaborator

@acatl acatl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making this PR, there are some types that are not part of datapoint please remove them

packages/data-point/data-point.d.ts Outdated
children: Array<RDOMElement | string>;
}

interface RDOMObject {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not exist in data-point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

packages/data-point/data-point.d.ts Outdated
interface TransformExpression {
}

interface ElementSpec {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not exist in data-point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

packages/data-point/data-point.d.ts Outdated
@@ -0,0 +1,36 @@
import * as React from 'react';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is outside the scope of data-point, please remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

packages/data-point/data-point.d.ts Outdated
@@ -0,0 +1,36 @@
import * as React from 'react';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this file be renamed index.d.ts ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov
Copy link

codecov bot commented Oct 12, 2019 •
edited
Loading

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #441   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         139    139           
  Lines        1982   1982           
  Branches      182    182           
=====================================
  Hits         1982   1982

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a97ff09...3472fc1. Read the comment docs.

@RamzesTheSecond RamzesTheSecond requested a review from acatl October 12, 2019 16:58
acatl
acatl approved these changes Oct 14, 2019
View reviewed changes
Copy link
Collaborator

@acatl acatl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@acatl acatl merged commit 27884e1 into ViacomInc:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatl acatl acatl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RamzesTheSecond @acatl