test: adds types for testing #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatl
commented
Sep 25, 2019
| "jest": "^24.8.0", | ||
| "lerna": "^3.15.0", | ||
| "lint-staged": "^9.2.0", | ||
| "prettier": "1.18.2", |
There was a problem hiding this comment.
yarn changed the order of these when installing the dependency
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 139 139
Lines 1982 1982
Branches 182 182
=====================================
Hits 1982 1982Continue to review full report at Codecov.
|
raingerber
approved these changes
Sep 25, 2019
arik223
approved these changes
Sep 25, 2019
jerryluna
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds types for testing
Why:
So we can get jest's type hints when writing tests.
How:
adding @types/jest
Checklist: