fix: Fix bug when the input to a reducer list is undefined #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 139 139
Lines 1981 1982 +1
Branches 181 182 +1
=====================================
+ Hits 1981 1982 +1
Continue to review full report at Codecov.
|
acatl
approved these changes
Jul 30, 2019
| @@ -153,3 +153,42 @@ describe('resolve#reducer.resolve - reducer request', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| describe('resolve#reducer.resolve - with falsy input', () => { | |||
| const testFalsyInput = async (inputValue, expectedValue) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What (Bugfix): Reducer lists currently skip the first reducer when the initial value is undefined
Why: #353
How: Use null as a fallback when the initial value for Promise.map is undefined
Checklist: