fix(data-point): replace util.inspect with json-stringify-safe #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change is to remove inconsistencies across node versions close ViacomInc#346
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 139 139
Lines 1997 1998 +1
Branches 181 181
=====================================
+ Hits 1997 1998 +1
Continue to review full report at Codecov.
|
raingerber
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
this change is to remove inconsistencies across node versions
Why:
see #346
Unblocks issue #344 and its PR #345
How:
using json-stringify-safe as a drop-in replacement
Checklist: