Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

274 add repo url to package json on any package #336

Merged
merged 5 commits into from
Jan 25, 2019
Merged

274 add repo url to package json on any package #336

merged 5 commits into from
Jan 25, 2019

Conversation

Vision87
Copy link
Contributor

@Vision87 Vision87 commented Jan 23, 2019 •
edited
Loading

What:
add repo url to package json on any package

Why:
issue labelled as "help wanted" and "good first issue"

How:
added on package.json the repo url to the correct path on github on each packages
added also missing url on main README, this update could be out of scope

Checklist:

  • Has Breaking changes
  • Documentation
  • Tests
  • Ready to be merged
  • Added username to all-contributors list

fixes #274

@Vision87 Vision87 requested a review from acatl January 23, 2019 17:13
@codecov
Copy link

codecov bot commented Jan 23, 2019 •
edited
Loading

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #336   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         139    139           
  Lines        1989   1989           
  Branches      183    183           
=====================================
  Hits         1989   1989

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a322fa...0181039. Read the comment docs.

raingerber
raingerber previously approved these changes Jan 23, 2019
View reviewed changes
@raingerber
Copy link
Contributor

can you add "fixes 274" to the description? https://help.github.com/articles/closing-issues-using-keywords/

acatl
acatl reviewed Jan 23, 2019
View reviewed changes
Copy link
Collaborator

@acatl acatl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

could you please add yourself as a contributor, we are using the all-contributors-cli module which you can use via the command line its exposed as a package.json script

@Vision87
Copy link
Contributor Author

can you add "fixes 274" to the description? https://help.github.com/articles/closing-issues-using-keywords/

done

@Vision87
Copy link
Contributor Author

thank you!!

could you please add yourself as a contributor, we are using the all-contributors-cli module which you can use via the command line its exposed as a package.json script

done

acatl
acatl approved these changes Jan 25, 2019
View reviewed changes
Copy link
Collaborator

@acatl acatl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you sir!!

@Vision87 Vision87 merged commit dff2548 into ViacomInc:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatl acatl acatl approved these changes

@raingerber raingerber raingerber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add repo url to package.json on any package that is missing it
4 participants
@Vision87 @raingerber @acatl @moioilia