-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with filtering out multiple void instances #11
Comments
Hi @marckatzenmaier, So at the end of the day, segments predicted for void objects are not ignored (though they should be), resulting in "false FP" (false positives that shouldn't be false positives). I think this line should be |
This is fixed now. |
Facing issue with : |
Hi @clotilda-0 I don't think your issue refers to the utae-paps repository as it does not contain an |
I run some tests with your implementation for the panoptic metric and got a curious result.
I made a simple test case with two instance who overlap the void class -> they should get filtered out.
if I have only one of those instances it works properly and I don’t get FP.
If I now have both instances they don’t get filtered out and I get two FP
It might have to do with
utae-paps/src/panoptic/metrics.py
Line 55 in 9e54d3c
since you here do the unique over basicly a binary mask if I understand correctly. I supect you wanted to do here instead of void_mask -> instance_ture[batch_idx]
The text was updated successfully, but these errors were encountered: