src/arith_256.cpp: bigendian compatibility

laanwj · laanwj · commit f4e6487219d4 · 2015-03-06T17:21:59.000+01:00
diff --git a/src/arith_uint256.cpp b/src/arith_uint256.cpp
@@ -7,6 +7,7 @@
 
 #include "uint256.h"
 #include "utilstrencodings.h"
+#include "crypto/common.h"
 
 #include <stdio.h>
 #include <string.h>
@@ -246,14 +247,14 @@ uint32_t arith_uint256::GetCompact(bool fNegative) const
 uint256 ArithToUint256(const arith_uint256 &a)
 {
     uint256 b;
-    // TODO: needs bswap32 on big-endian
-    memcpy(b.begin(), a.pn, a.size());
+    for(int x=0; x<a.WIDTH; ++x)
+        WriteLE32(b.begin() + x*4, a.pn[x]);
     return b;
 }
 arith_uint256 UintToArith256(const uint256 &a)
 {
     arith_uint256 b;
-    // TODO: needs bswap32 on big-endian
-    memcpy(b.pn, a.begin(), a.size());
+    for(int x=0; x<b.WIDTH; ++x)
+        b.pn[x] = ReadLE32(a.begin() + x*4);
     return b;
 }

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`
`8`	`8`	`#include "uint256.h"`
`9`	`9`	`#include "utilstrencodings.h"`
	`10`	`+#include "crypto/common.h"`
`10`	`11`
`11`	`12`	`#include <stdio.h>`
`12`	`13`	`#include <string.h>`
`@@ -246,14 +247,14 @@ uint32_t arith_uint256::GetCompact(bool fNegative) const`
`246`	`247`	`uint256 ArithToUint256(const arith_uint256 &a)`
`247`	`248`	`{`
`248`	`249`	`uint256 b;`
`249`		`- // TODO: needs bswap32 on big-endian`
`250`		`- memcpy(b.begin(), a.pn, a.size());`
	`250`	`+ for(int x=0; x<a.WIDTH; ++x)`
	`251`	`+ WriteLE32(b.begin() + x*4, a.pn[x]);`
`251`	`252`	`return b;`
`252`	`253`	`}`
`253`	`254`	`arith_uint256 UintToArith256(const uint256 &a)`
`254`	`255`	`{`
`255`	`256`	`arith_uint256 b;`
`256`		`- // TODO: needs bswap32 on big-endian`
`257`		`- memcpy(b.pn, a.begin(), a.size());`
	`257`	`+ for(int x=0; x<b.WIDTH; ++x)`
	`258`	`+ b.pn[x] = ReadLE32(a.begin() + x*4);`
`258`	`259`	`return b;`
`259`	`260`	`}`