qt: fix 'opens in testnet mode when presented with a BIP-72 link with no fallback'

haight6716 · laanwj · commit dd49e92fb0ca · 2014-07-02T09:47:47.000+02:00
Passes tests: ``` $ ./bitcoin-qt 'bitcoin:?r=http://www.example.com/' .. fixed the original problem - this launches mainnet. $ ./bitcoin-qt 'bitcoin:mngeNQbTKnmaMbx8EXCYdwUbnt9JJD52cC' .. launches testnet $ ./bitcoin-qt -testnet 'bitcoin:1NXXeQRyMFFFRfyUix2o7mk1vhvk2Nxp78' .. sanity check - launches mainnet. ``` Fixes #4355. Closes #4411.
diff --git a/src/qt/paymentserver.cpp b/src/qt/paymentserver.cpp
@@ -195,7 +195,7 @@ bool PaymentServer::ipcParseCommandLine(int argc, char* argv[])
             savedPaymentRequests.append(arg);
 
             SendCoinsRecipient r;
-            if (GUIUtil::parseBitcoinURI(arg, &r))
+            if (GUIUtil::parseBitcoinURI(arg, &r) && !r.address.isEmpty())
             {
                 CBitcoinAddress address(r.address.toStdString());
 

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ bool PaymentServer::ipcParseCommandLine(int argc, char* argv[])`
`195`	`195`	`savedPaymentRequests.append(arg);`
`196`	`196`
`197`	`197`	`SendCoinsRecipient r;`
`198`		`- if (GUIUtil::parseBitcoinURI(arg, &r))`
	`198`	`+ if (GUIUtil::parseBitcoinURI(arg, &r) && !r.address.isEmpty())`
`199`	`199`	`{`
`200`	`200`	`CBitcoinAddress address(r.address.toStdString());`
`201`	`201`