Merge pull request #4670

laanwj · laanwj · commit dd2819701a1a · 2014-08-19T12:23:56.000+02:00
a35b55b Dont run full check every time we decrypt wallet. (Matt Corallo) 1e21c17 Make CCryptoKeyStore::Unlock check all keys. (Gregory Maxwell)
diff --git a/src/crypter.cpp b/src/crypter.cpp
@@ -152,23 +152,44 @@ bool CCryptoKeyStore::Unlock(const CKeyingMaterial& vMasterKeyIn)
         if (!SetCrypted())
             return false;
 
+        bool keyPass = false;
+        bool keyFail = false;
         CryptedKeyMap::const_iterator mi = mapCryptedKeys.begin();
         for (; mi != mapCryptedKeys.end(); ++mi)
         {
             const CPubKey &vchPubKey = (*mi).second.first;
             const std::vector<unsigned char> &vchCryptedSecret = (*mi).second.second;
             CKeyingMaterial vchSecret;
             if(!DecryptSecret(vMasterKeyIn, vchCryptedSecret, vchPubKey.GetHash(), vchSecret))
-                return false;
+            {
+                keyFail = true;
+                break;
+            }
             if (vchSecret.size() != 32)
-                return false;
+            {
+                keyFail = true;
+                break;
+            }
             CKey key;
             key.Set(vchSecret.begin(), vchSecret.end(), vchPubKey.IsCompressed());
-            if (key.GetPubKey() == vchPubKey)
+            if (key.GetPubKey() != vchPubKey)
+            {
+                keyFail = true;
                 break;
-            return false;
+            }
+            keyPass = true;
+            if (fDecryptionThoroughlyChecked)
+                break;
+        }
+        if (keyPass && keyFail)
+        {
+            LogPrintf("The wallet is probably corrupted: Some keys decrypt but not all.");
+            assert(false);
         }
+        if (keyFail || !keyPass)
+            return false;
         vMasterKey = vMasterKeyIn;
+        fDecryptionThoroughlyChecked = true;
     }
     NotifyStatusChanged(this);
     return true;
diff --git a/src/crypter.h b/src/crypter.h
@@ -121,6 +121,9 @@ class CCryptoKeyStore : public CBasicKeyStore
     // if fUseCrypto is false, vMasterKey must be empty
     bool fUseCrypto;
 
+    // keeps track of whether Unlock has run a thourough check before
+    bool fDecryptionThoroughlyChecked;
+
 protected:
     bool SetCrypted();
 
@@ -130,7 +133,7 @@ class CCryptoKeyStore : public CBasicKeyStore
     bool Unlock(const CKeyingMaterial& vMasterKeyIn);
 
 public:
-    CCryptoKeyStore() : fUseCrypto(false)
+    CCryptoKeyStore() : fUseCrypto(false), fDecryptionThoroughlyChecked(false)
     {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -121,6 +121,9 @@ class CCryptoKeyStore : public CBasicKeyStore`
`121`	`121`	`// if fUseCrypto is false, vMasterKey must be empty`
`122`	`122`	`bool fUseCrypto;`
`123`	`123`
	`124`	`+ // keeps track of whether Unlock has run a thourough check before`
	`125`	`+ bool fDecryptionThoroughlyChecked;`
	`126`	`+`
`124`	`127`	`protected:`
`125`	`128`	`bool SetCrypted();`
`126`	`129`
`@@ -130,7 +133,7 @@ class CCryptoKeyStore : public CBasicKeyStore`
`130`	`133`	`bool Unlock(const CKeyingMaterial& vMasterKeyIn);`
`131`	`134`
`132`	`135`	`public:`
`133`		`- CCryptoKeyStore() : fUseCrypto(false)`
	`136`	`+ CCryptoKeyStore() : fUseCrypto(false), fDecryptionThoroughlyChecked(false)`
`134`	`137`	`{`
`135`	`138`	`}`
`136`	`139`