Skip to content

Commit aaba10f

Browse files
committed
Revert "Make nicer pull request merge messages"
This reverts commit 1078fb0 (and thus pull #5623). It has various issues: - Pull request names get cut off at ", see e.g. a026a56 - Merge script no longer copes with pulls that have a milestone attached, due to a duplicate 'title' in JSON that is not handled by the ad-hoc parsing.
1 parent a026a56 commit aaba10f

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

contrib/devtools/github-merge.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,15 +82,13 @@ function cleanup() {
8282
}
8383

8484
# Create unsigned merge commit.
85-
PRTITLE=`curl -s https://api.github.com/repos/$REPO/pulls/$PULL | grep -e ' "title": ".*",'| awk -F'"' '{print $4}'`
86-
MERGEMESSAGE="Merge #$PULL: $PRTITLE"
8785
(
88-
echo $MERGEMESSAGE
86+
echo "Merge pull request #$PULL"
8987
echo ""
9088
git log --no-merges --topo-order --pretty='format:%h %s (%an)' pull/"$PULL"/base..pull/"$PULL"/head
9189
)>"$TMPDIR/message"
9290
if git merge -q --commit --no-edit --no-ff -m "$(<"$TMPDIR/message")" pull/"$PULL"/head; then
93-
if [ "d$(git log --pretty='format:%s' -n 1)" != "d$MERGEMESSAGE" ]; then
91+
if [ "d$(git log --pretty='format:%s' -n 1)" != "dMerge pull request #$PULL" ]; then
9492
echo "ERROR: Creating merge failed (already merged?)." >&2
9593
cleanup
9694
exit 4

0 commit comments

Comments
 (0)