Skip to content

Commit 8a7f37c

Browse files
committed
qt: use SendCoinsRecipient for payment request information
This brings some symmetry into the design by using the same object both for incoming URIs that are parsed as for outgoing URIs that are formatted.
1 parent 03535ac commit 8a7f37c

File tree

3 files changed

+18
-14
lines changed

3 files changed

+18
-14
lines changed

src/qt/receivecoinsdialog.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,9 @@ void ReceiveCoinsDialog::on_receiveButton_clicked()
9696
/* Generate new receiving address */
9797
address = model->getAddressTableModel()->addRow(AddressTableModel::Receive, label, "");
9898
}
99-
ReceiveRequestDialog *dialog = new ReceiveRequestDialog(address, label,
100-
ui->reqAmount->value(), ui->reqMessage->text(), this);
99+
SendCoinsRecipient info(address, label,
100+
ui->reqAmount->value(), ui->reqMessage->text());
101+
ReceiveRequestDialog *dialog = new ReceiveRequestDialog(info, this);
101102
dialog->setModel(model->getOptionsModel());
102103
dialog->setAttribute(Qt::WA_DeleteOnClose);
103104
dialog->show();

src/qt/receiverequestdialog.cpp

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#include "guiconstants.h"
66
#include "guiutil.h"
77
#include "optionsmodel.h"
8+
#include "walletmodel.h"
89

910
#include <QPixmap>
1011
#include <QClipboard>
@@ -63,25 +64,25 @@ void QRImageWidget::copyImage()
6364
QApplication::clipboard()->setImage(exportImage());
6465
}
6566

66-
ReceiveRequestDialog::ReceiveRequestDialog(const QString &addr, const QString &label, quint64 amount, const QString &message, QWidget *parent) :
67+
ReceiveRequestDialog::ReceiveRequestDialog(const SendCoinsRecipient &info, QWidget *parent) :
6768
QDialog(parent),
6869
ui(new Ui::ReceiveRequestDialog),
6970
model(0),
70-
address(addr)
71+
info(info)
7172
{
7273
ui->setupUi(this);
7374

74-
QString target = label;
75+
QString target = info.label;
7576
if(target.isEmpty())
76-
target = addr;
77+
target = info.address;
7778
setWindowTitle(tr("Request payment to %1").arg(target));
7879

79-
ui->lnAddress->setText(addr);
80-
if(amount)
81-
ui->lnReqAmount->setValue(amount);
80+
ui->lnAddress->setText(info.address);
81+
if(info.amount)
82+
ui->lnReqAmount->setValue(info.amount);
8283
ui->lnReqAmount->setReadOnly(true);
83-
ui->lnLabel->setText(label);
84-
ui->lnMessage->setText(message);
84+
ui->lnLabel->setText(info.label);
85+
ui->lnMessage->setText(info.message);
8586

8687
#ifndef USE_QRCODE
8788
ui->btnSaveAs->setVisible(false);
@@ -146,7 +147,7 @@ void ReceiveRequestDialog::genCode()
146147

147148
QString ReceiveRequestDialog::getURI()
148149
{
149-
QString ret = QString("bitcoin:%1").arg(address);
150+
QString ret = QString("bitcoin:%1").arg(info.address);
150151
int paramCount = 0;
151152

152153
if (ui->lnReqAmount->validate())

src/qt/receiverequestdialog.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
#ifndef QRCODEDIALOG_H
22
#define QRCODEDIALOG_H
33

4+
#include "walletmodel.h"
5+
46
#include <QDialog>
57
#include <QImage>
68
#include <QLabel>
@@ -34,7 +36,7 @@ class ReceiveRequestDialog : public QDialog
3436
Q_OBJECT
3537

3638
public:
37-
explicit ReceiveRequestDialog(const QString &addr, const QString &label, quint64 amount, const QString &message, QWidget *parent = 0);
39+
explicit ReceiveRequestDialog(const SendCoinsRecipient &info, QWidget *parent = 0);
3840
~ReceiveRequestDialog();
3941

4042
void setModel(OptionsModel *model);
@@ -49,7 +51,7 @@ private slots:
4951
private:
5052
Ui::ReceiveRequestDialog *ui;
5153
OptionsModel *model;
52-
QString address;
54+
SendCoinsRecipient info;
5355

5456
void genCode();
5557
QString getURI();

0 commit comments

Comments
 (0)