[rpcwallet] Don't use floating point

MarcoFalke · MarcoFalke · commit 477777f2503e · 2016-07-08T12:01:25.000+02:00
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -564,8 +564,8 @@ UniValue getreceivedbyaddress(const UniValue& params, bool fHelp)
     if (!address.IsValid())
         throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid Bitcoin address");
     CScript scriptPubKey = GetScriptForDestination(address.Get());
-    if (!IsMine(*pwalletMain,scriptPubKey))
-        return (double)0.0;
+    if (!IsMine(*pwalletMain, scriptPubKey))
+        return ValueFromAmount(0);
 
     // Minimum confirmations
     int nMinDepth = 1;
@@ -643,7 +643,7 @@ UniValue getreceivedbyaccount(const UniValue& params, bool fHelp)
         }
     }
 
-    return (double)nAmount / (double)COIN;
+    return ValueFromAmount(nAmount);
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -564,8 +564,8 @@ UniValue getreceivedbyaddress(const UniValue& params, bool fHelp)`
`564`	`564`	`if (!address.IsValid())`
`565`	`565`	`throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid Bitcoin address");`
`566`	`566`	`CScript scriptPubKey = GetScriptForDestination(address.Get());`
`567`		`- if (!IsMine(*pwalletMain,scriptPubKey))`
`568`		`- return (double)0.0;`
	`567`	`+ if (!IsMine(*pwalletMain, scriptPubKey))`
	`568`	`+ return ValueFromAmount(0);`
`569`	`569`
`570`	`570`	`// Minimum confirmations`
`571`	`571`	`int nMinDepth = 1;`
`@@ -643,7 +643,7 @@ UniValue getreceivedbyaccount(const UniValue& params, bool fHelp)`
`643`	`643`	`}`
`644`	`644`	`}`
`645`	`645`
`646`		`- return (double)nAmount / (double)COIN;`
	`646`	`+ return ValueFromAmount(nAmount);`
`647`	`647`	`}`
`648`	`648`
`649`	`649`