Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 524 feat add directives to core #525

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

alvarosabu
Copy link
Member

Closes #524

Copy link

netlify bot commented Jan 27, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit dc4e4c1
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/65b53ffe204d6c0008d0bba5
😎 Deploy Preview https://deploy-preview-525--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JaimeTorrealba
Copy link
Member

I have this one Tresjs/cientos#337 already in review. Could we merge this and then move them here?

Or do you prefer to create this branch in this repo?

Also when finish this, please don't forget to delete in cientos :)

Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, everything seems fine. But please check the last comment and tell me how to proceed.
Thanks for the TS improvements, look nice.

@alvarosabu
Copy link
Member Author

Or do you prefer to create this branch in this repo?

Lets create a PR here on the core for this one and close the one in cientos @JaimeTorrealba

Thanks

@alvarosabu alvarosabu merged commit 5268e9f into main Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

feat: add directives to core
2 participants